gh-152142: Fix inverted DOMBuilderFilter result for notation declarations#152143
Open
tonghuaroot wants to merge 1 commit into
Open
gh-152142: Fix inverted DOMBuilderFilter result for notation declarations#152143tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…clarations xml.dom.expatbuilder.notation_decl_handler dropped a notation when the DOMBuilderFilter accepted it and kept it when the filter rejected it, the inverse of entity_decl_handler and the DOMBuilderFilter contract. Compare against FILTER_REJECT like the other handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notation_decl_handlerdeleted a notation when theDOMBuilderFilteraccepted it and kept it when the filter rejected it, the inverse ofentity_decl_handlerand the other filtered handlers. Compare againstFILTER_REJECTlike the rest, and add a regression test.Fixes #152142.