gh-152093: Fix test_tk_caret() on macOS#152115
Merged
serhiy-storchaka merged 1 commit intoJun 24, 2026
Merged
Conversation
macOS records the caret only for the key window, so the query reads back zeros instead of the values set in the test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS the caret position is recorded only while the window is the key (active) window:
Tk_SetCaretPos()returns early without updating the display's caret when. On X11 it is always stored.In the GHA macOS job the test's window is not the key window, so the set is a no-op and the query reads back the default zeroed position, failing the equality assertion. On Aqua the test now checks only that the query returns the expected keys; the exact round-trip is still verified on the other platforms.