gh-152042: Preserve instance __dict__ when copying deque and array subclasses#152043
Open
iamsharduld wants to merge 1 commit into
Open
gh-152042: Preserve instance __dict__ when copying deque and array subclasses#152043iamsharduld wants to merge 1 commit into
iamsharduld wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy.copy()of acollections.dequesubclass, and bothcopy.copy()andcopy.deepcopy()of anarray.arraysubclass, dropped the instance__dict__. Forarraythe result was also a plainarrayrather than the subclass.pickleand thelist/dict/setsubclasses don't have this problem, so the behavior was inconsistent.deque.__copy__(shared withdeque.copy()) now copies the instance__dict__onto the new object.array.__copy__/__deepcopy__now build the actual subclass and copy the__dict__— shallow for__copy__, deep (via the memo) for__deepcopy__, registering the new object in the memo first so self-referential attributes don't recurse forever.Both types'
__reduce_ex__already carried this state, which is whypickle(anddeepcopyof a deque, which has no__deepcopy__) were already correct.Fixes #152042.