gh-151496: Use process groups in TraceBackend in test_dtrace#152039
Open
stratakis wants to merge 1 commit into
Open
gh-151496: Use process groups in TraceBackend in test_dtrace#152039stratakis wants to merge 1 commit into
stratakis wants to merge 1 commit into
Conversation
Run the generic DTrace/SystemTap commands in a new process group and terminate the whole group on timeout. This prevents a forked tracer child from keeping stdout/stderr pipes open after the direct tracer process is killed.
Contributor
Author
|
cc @vstinner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the generic DTrace/SystemTap commands in a new process group and terminate the whole group on timeout.
This prevents a forked tracer child from keeping stdout/stderr pipes open after the direct tracer process is killed.
Followup to #151512
test_dtracecan hang indefinitely when bpftrace usability check times out #151496