gh-148529: Accept any contiguous bytes-like object for the struct 's' and 'p' formats#152029
Open
iamsharduld wants to merge 1 commit into
Open
gh-148529: Accept any contiguous bytes-like object for the struct 's' and 'p' formats#152029iamsharduld wants to merge 1 commit into
iamsharduld wants to merge 1 commit into
Conversation
…ct 's' and 'p' formats
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struct.pack(andpack_into/Struct.pack) only acceptedbytesandbytearrayfor thesandpformat codes. Passing any other buffer —memoryview,array.array,mmap, ... — failed withstruct.error, even though it's a contiguous chunk of bytes that can be copied straight in:Both codes now accept any contiguous bytes-like object.
bytes/bytearraykeep their existing fast path; anything else goes through the buffer protocol (PyObject_GetBufferwithPyBUF_SIMPLE), and the buffer is released on every exit path. Non-contiguous buffers and objects that don't expose a buffer still raisestruct.error(with a slightly clearer message now).serhiy-storchaka said as much on the issue — "there is no reason to limit it to bytes and bytearray, any object providing continuous buffer can be supported".
Added a regression test covering
memoryviewandarray.arraythroughpack,pack_intoandStruct.pack, and updated the docs, which until now spelled out the bytes/bytearray-only restriction.struct.packwith formatserrors onbytes-like data #148529