Skip to content

gh-84649: Fix unstable test_rollover_at_midnight #151813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
Jun 20, 2026
+15 −10
Merged

gh-84649: Fix unstable test_rollover_at_midnight #151813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6705,20 +6705,18 @@ def add_record(message: str) -> None:

def test_rollover_at_midnight(self, weekly=False):
os_helper.unlink(self.fn)
# Emit the first records a little after the beginning of a whole
# second, so that their file times fall inside that second and not the
# previous one, which would cause an unwanted rollover.
now = datetime.datetime.now()
atTime = now.time()
if not 0.1 < atTime.microsecond/1e6 < 0.9:
# The test requires all records to be emitted within
# the range of the same whole second.
time.sleep((0.1 - atTime.microsecond/1e6) % 1.0)
if not 0.1 < now.microsecond/1e6 < 0.9:
time.sleep((0.1 - now.microsecond/1e6) % 1.0)
now = datetime.datetime.now()
atTime = now.time()
atTime = atTime.replace(microsecond=0)
fmt = logging.Formatter('%(asctime)s %(message)s')
when = f'W{now.weekday()}' if weekly else 'MIDNIGHT'
for i in range(3):
fh = logging.handlers.TimedRotatingFileHandler(
self.fn, encoding="utf-8", when=when, atTime=atTime)
self.fn, encoding="utf-8", when=when, atTime=now.time())
fh.setFormatter(fmt)
r2 = logging.makeLogRecord({'msg': f'testing1 {i}'})
fh.emit(r2)
Expand All @@ -6728,15 +6726,22 @@ def test_rollover_at_midnight(self, weekly=False):
for i, line in enumerate(f):
self.assertIn(f'testing1 {i}', line)

os.utime(self.fn, (now.timestamp() - 1,)*2)
# The creation time, used to compute the rollover time, cannot be
# changed, so the rollover cannot be forced by back-dating the file.
# Wait until the clock reaches a rollover time set one second ahead.
rollover = int(time.time()) + 1
atTime = datetime.datetime.fromtimestamp(rollover).time()
while time.time() < rollover:
time.sleep(rollover - time.time())
for i in range(2):
fh = logging.handlers.TimedRotatingFileHandler(
self.fn, encoding="utf-8", when=when, atTime=atTime)
fh.setFormatter(fmt)
r2 = logging.makeLogRecord({'msg': f'testing2 {i}'})
fh.emit(r2)
fh.close()
rolloverDate = now - datetime.timedelta(days=7 if weekly else 1)
rolloverDate = (datetime.datetime.fromtimestamp(rollover)
- datetime.timedelta(days=7 if weekly else 1))
otherfn = f'{self.fn}.{rolloverDate:%Y-%m-%d}'
self.assertLogFile(otherfn)
with open(self.fn, encoding="utf-8") as f:
Expand Down
Loading