gh-151644: Fix data race in sys.setdlopenflags/getdlopenflags under free-threading#151768
Open
zangjiucheng wants to merge 2 commits into
Open
gh-151644: Fix data race in sys.setdlopenflags/getdlopenflags under free-threading#151768zangjiucheng wants to merge 2 commits into
zangjiucheng wants to merge 2 commits into
Conversation
…nder free-threading In free-threading builds, concurrent calls to sys.getdlopenflags() and sys.setdlopenflags() race on interp->imports.dlopenflags. Fix by using FT_ATOMIC_LOAD_INT_RELAXED / FT_ATOMIC_STORE_INT_RELAXED in _PyImport_GetDLOpenFlags and _PyImport_SetDLOpenFlags, consistent with how analogous interpreter-state integer fields (lazy_imports_mode, pystats_enabled) are protected. Relaxed ordering is correct here: dlopenflags is a standalone config integer with no ordering relationship to other memory. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In free-threading builds, concurrent calls to
sys.getdlopenflags()andsys.setdlopenflags()race oninterp->imports.dlopenflags— a plainintfield read and written with no synchronisation.
Fix
Replace the bare load/store in
_PyImport_GetDLOpenFlags/_PyImport_SetDLOpenFlagswithFT_ATOMIC_LOAD_INT_RELAXED/FT_ATOMIC_STORE_INT_RELAXED.Atomics are preferred over
PyMutex(used for the analogoubecause each access is a single load or store — no multi-field consistency
guarantee is needed. Relaxed ordering is correct:
dlopenfl standalone config integer with no ordering relationship to other memory, consistent with howlazy_imports_modeandpystats_enablein the same file.
_PyImport_SetDLOpenFlagswhensys.setdlopenflags()is called concurrently #151644