GH-151619: Ensure non-module global/builtin namespaces are watched for lazy imports#151762
Open
brandtbucher wants to merge 2 commits into
Open
GH-151619: Ensure non-module global/builtin namespaces are watched for lazy imports#151762brandtbucher wants to merge 2 commits into
brandtbucher wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using non-module global or builtin namespaces (such as dictionaries passed to
exec) can currently cause cached global loads to produce unresolved lazy imports. Check for this and make sure all relevant namespaces are watched when specializing global loads.Separately: this patch preserves the behavior that lazy imports in the builtins are resolved when they're looked up. This seems like sort of a niche edge case, but I think the current behavior makes sense (
builtinsis a module, after all).