gh-139140: Document that reading __annotations__ via __dict__ is unre…#151750
Open
Builder106 wants to merge 1 commit into
Open
gh-139140: Document that reading __annotations__ via __dict__ is unre…#151750Builder106 wants to merge 1 commit into
Builder106 wants to merge 1 commit into
Conversation
…s unreliable on Python 3.14+
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Annotations Best Practices" HOWTO recommended reading a class's annotations via
cls.__dict__.get('__annotations__', None)as a general fallback for "earlier versions of Python." Under PEP 649/749 (Python 3.14), annotations are evaluated lazily, and how they're stored in the class__dict__is a private implementation detail, so that pattern is no longer reliable on 3.14+.This re-scopes the
__dict__workaround to Python 3.9 and earlier (where neitherinspect.get_annotationsnorannotationlib.get_annotationsis available), and adds a note directing 3.14+ readers toannotationlib.get_annotations/inspect.get_annotationsinstead.Docs-only change; no
Misc/NEWS.dentry needed.Fixes #139140
__annotations__through__dict__no longer works #139140