Skip to content

gh-151556: Show sample CSV file content in csv module docs#151563

Merged
StanFromIreland merged 9 commits into
python:mainfrom
lul-cas:gh-151556
Jun 23, 2026
Merged

gh-151556: Show sample CSV file content in csv module docs#151563
StanFromIreland merged 9 commits into
python:mainfrom
lul-cas:gh-151556

Conversation

@lul-cas

@lul-cas lul-cas commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Fixes gh-151556

@python-cla-bot

python-cla-bot Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jun 16, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 16, 2026
Closed
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 16, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33269802 | 📁 Comparing c37b277 against main (c2ca772)

  🔍 Preview build  

35 files changed · ± 35 modified

± Modified

StanFromIreland
StanFromIreland reviewed Jun 17, 2026
View reviewed changes
Comment thread Doc/library/csv.rst Outdated
Comment thread Doc/library/csv.rst Outdated
@lul-cas lul-cas requested a review from StanFromIreland June 17, 2026 13:34
StanFromIreland
StanFromIreland reviewed Jun 22, 2026
View reviewed changes
Comment thread Doc/library/csv.rst Outdated
@lul-cas lul-cas requested a review from StanFromIreland June 22, 2026 16:57
StanFromIreland
StanFromIreland reviewed Jun 23, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two final little wording changes :-)

Comment thread Doc/library/csv.rst Outdated
Comment thread Doc/library/csv.rst Outdated
lul-cas and others added 2 commits June 23, 2026 08:51
@lul-cas @StanFromIreland
pythongh-151556: Tweak wording of writer example file output
3da4caa 
Apply changes from code review.
Co-authored-by: Stan Ulbrych <stan@python.org>

Co-authored-by: Stan Ulbrych <stan@python.org>
@lul-cas
Merge branch 'main' into pythongh-151556
c37b277
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 23, 2026
StanFromIreland
StanFromIreland approved these changes Jun 23, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland StanFromIreland merged commit 7915c4a into python:main Jun 23, 2026
40 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 23, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 23, 2026

Copy link
Copy Markdown

Thanks @lul-cas for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 23, 2026

Copy link
Copy Markdown

GH-151984 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 23, 2026
@bedevere-app

bedevere-app Bot commented Jun 23, 2026

Copy link
Copy Markdown

GH-151985 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 23, 2026
@bedevere-app

bedevere-app Bot commented Jun 23, 2026

Copy link
Copy Markdown

GH-151986 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 23, 2026
StanFromIreland added a commit that referenced this pull request Jun 23, 2026
@miss-islington @lul-cas @StanFromIreland
[3.13] gh-151556: Show example CSV file content in the csv module d…
82e023f 
…ocs (GH-151563) (#151986)

(cherry picked from commit 7915c4a)

Co-authored-by: Lucas <lucasefernandes333@gmail.com>
Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Jun 23, 2026
@miss-islington @lul-cas @StanFromIreland
[3.14] gh-151556: Show example CSV file content in the csv module d…
3ae0639 
…ocs (GH-151563) (#151985)

(cherry picked from commit 7915c4a)

Co-authored-by: Lucas <lucasefernandes333@gmail.com>
Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Jun 23, 2026
@miss-islington @lul-cas @StanFromIreland
[3.15] gh-151556: Show example CSV file content in the csv module d…
b34a86f 
…ocs (GH-151563)

(cherry picked from commit 7915c4a)

Co-authored-by: Lucas <lucasefernandes333@gmail.com>
Co-authored-by: Stan Ulbrych <stan@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CSV documentation doesn't provide example input

2 participants

@lul-cas @StanFromIreland