gh-151532: Validate xmlrpc.client.dumps() arguments under -O#151533
Open
zainnadeem786 wants to merge 1 commit into
Open
gh-151532: Validate xmlrpc.client.dumps() arguments under -O#151533zainnadeem786 wants to merge 1 commit into
zainnadeem786 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-151532.
xmlrpc.client.dumps()currently usesassertstatements to validate public API arguments. When Python is executed with optimization enabled (python -O), those assertions are removed, causing invalid inputs to be accepted and serialized instead of being rejected.This change replaces the assertion-based validation with explicit runtime checks so behavior remains consistent regardless of optimization mode.
Reproduction
Before this change:
Normal execution:
Optimized execution (
python -O):Similarly:
Normal execution:
Optimized execution (
python -O):Because the validation relied on assertions, invalid inputs were silently accepted when optimization was enabled.
Changes
assertthat validatesparamswith an explicitTypeError.assertthat validatesmethodresponse=Trueresponse tuples with an explicitValueError.python -O) subprocess test to verify validation remains enforced when assertions are disabled.Tests
Added regression coverage for:
paramsvalues (list,dict,str,int)methodresponse=Truetuple lengthspython -OAfter this change, invalid inputs are rejected consistently in both normal and optimized execution modes.
Issue: gh-151532