Skip to content

gh-151526: Add csv writer tests for quote style edge cases #151527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doma17 wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −2
Open

gh-151526: Add csv writer tests for quote style edge cases #151527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions Lib/test/test_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ def _test_arg_valid(self, ctor, arg):
self.assertRaises(TypeError, ctor, arg, quoting=None)
self.assertRaises(TypeError, ctor, arg,
quoting=csv.QUOTE_ALL, quotechar='')
self.assertRaises(TypeError, ctor, arg,
quoting=csv.QUOTE_ALL, quotechar=None)
for quoting in csv.QUOTE_ALL, csv.QUOTE_STRINGS, csv.QUOTE_NOTNULL:
self.assertRaises(TypeError, ctor, arg,
quoting=quoting, quotechar=None)
self.assertRaises(TypeError, ctor, arg,
quoting=csv.QUOTE_NONE, quotechar='')
self.assertRaises(ValueError, ctor, arg, delimiter='\n')
Expand Down Expand Up @@ -259,6 +260,22 @@ def test_write_escape(self):
self._write_test(['C\\', '6', '7', 'X"'], 'C\\\\,6,7,"X"""',
escapechar='\\', quoting=csv.QUOTE_MINIMAL)

def test_write_quote_styles_escape(self):
self._write_test(['a"b', 'x\\y', 1, None],
'"a""b","x\\\\y",1,',
quoting=csv.QUOTE_STRINGS, escapechar='\\')
self._write_test(['a"b', 'x\\y', 1, None],
'"a\\"b","x\\\\y",1,',
quoting=csv.QUOTE_STRINGS, escapechar='\\',
doublequote=False)
self._write_test(['a"b', 'x\\y', 1, None],
'"a""b","x\\\\y","1",',
quoting=csv.QUOTE_NOTNULL, escapechar='\\')
self._write_test(['a"b', 'x\\y', 1, None],
'"a\\"b","x\\\\y","1",',
quoting=csv.QUOTE_NOTNULL, escapechar='\\',
doublequote=False)

def test_write_lineterminator(self):
for lineterminator in '\r\n', '\n', '\r', '!@#', '\0':
with self.subTest(lineterminator=lineterminator):
Expand Down
Loading