Skip to content

gh-151524: Avoid using instrumentation callback result after Py_DECREF #151525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpyu001 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

gh-151524: Avoid using instrumentation callback result after Py_DECREF #151525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4cc0af
gh-151524: Avoid using instrumentation callback result after Py_DECREF
lpyu001 Jun 16, 2026
137a1bf
add NEWS
lpyu001 Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-06-16-13-50-13.gh-issue-151377.mCqrGg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Avoid comparing the result of a ``sys.monitoring`` callback after

@sobolevn sobolevn Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a user-facing news entry. Users care about crashes (which could happen here), not about RC :)
Let's rephrase it.

decrementing its reference count.
3 changes: 2 additions & 1 deletion Python/instrumentation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,8 +989,9 @@ call_one_instrument(
if (res == NULL) {
return -1;
}
int is_disable = (res == &_PyInstrumentation_DISABLE);
Py_DECREF(res);
return (res == &_PyInstrumentation_DISABLE);
return is_disable;
}

static const int8_t MOST_SIGNIFICANT_BITS[16] = {
Expand Down
Loading