Skip to content

gh-151519: Check effective gid in _test_all_chown_common group-0 guard #151521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itamaro wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

gh-151519: Check effective gid in _test_all_chown_common group-0 guard #151521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/test/test_os/test_posix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,9 @@ def check_stat(uid, gid):
self.assertRaises(OSError, chown_func, first_param, 0, -1)
check_stat(uid, gid)
if hasattr(os, 'getgroups'):
if 0 not in os.getgroups():
# Also check the effective gid, which the kernel
# accepts for chown even if not in getgroups().
if 0 not in os.getgroups() and os.getegid() != 0:
self.assertRaises(OSError, chown_func, first_param, -1, 0)
check_stat(uid, gid)
# test illegal types
Expand Down
Loading