Skip to content

gh-151496: Use process groups in test_dtrace #151512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vstinner wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −4
Open

gh-151496: Use process groups in test_dtrace #151512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
665bb1d
gh-151496: Use process groups in test_dtrace
vstinner Jun 15, 2026
81ebe07
Simplify kill_process_group()
vstinner Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions Lib/test/test_dtrace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import dis
import os.path
import re
import signal
import subprocess
import sys
import sysconfig
Expand Down Expand Up @@ -50,6 +51,20 @@ def normalize_trace_output(output):
)


USE_PROCESS_GROUP = (hasattr(os, "setsid") and hasattr(os, "killpg"))

def create_process_group(*args, **kwargs):
if USE_PROCESS_GROUP:
kwargs['start_new_session'] = True
return subprocess.Popen(*args, **kwargs)

def kill_process_group(proc):
if USE_PROCESS_GROUP:
os.killpg(proc.pid, signal.SIGKILL)

@stratakis stratakis Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

   try:
       os.killpg(proc.pid, signal.SIGKILL)
   except ProcessLookupError:
       pass

else:
proc.kill()


class TraceBackend:
EXTENSION = None
COMMAND = None
Expand Down Expand Up @@ -205,15 +220,15 @@ def run_case(self, name, optimize_python=None):
program = self.PROGRAMS[name].format(python=sys.executable)

try:
proc = subprocess.Popen(
proc = create_process_group(
["bpftrace", "-e", program, "-c", " ".join(subcommand)],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
universal_newlines=True,
)
stdout, stderr = proc.communicate(timeout=60)
except subprocess.TimeoutExpired:
proc.kill()
kill_process_group(proc)

@stratakis stratakis Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proc.communicate() # Clean up

raise AssertionError("bpftrace timed out")
except (FileNotFoundError, PermissionError) as e:
raise unittest.SkipTest(f"bpftrace not available: {e}")
Expand Down Expand Up @@ -243,15 +258,15 @@ def assert_usable(self):
# Check if bpftrace is available and can attach to USDT probes
program = f'usdt:{sys.executable}:python:function__entry {{ printf("probe: success\\n"); exit(); }}'
try:
proc = subprocess.Popen(
proc = create_process_group(
["bpftrace", "-e", program, "-c", f"{sys.executable} -c pass"],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
universal_newlines=True,
)
stdout, stderr = proc.communicate(timeout=10)
except subprocess.TimeoutExpired:
proc.kill()
kill_process_group(proc)
proc.communicate() # Clean up
raise unittest.SkipTest("bpftrace timed out during usability check")
except OSError as e:
Expand Down
Loading