Skip to content

bpo-37765: Add keywords to IDLE tab completions #15138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 12 commits into from
Jul 9, 2020
Merged

bpo-37765: Add keywords to IDLE tab completions #15138

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
15b9ba0
bpo-37765: Add keywords to IDLE's main completion list
terryjreedy Aug 5, 2019
e8e0dfa
Merge remote-tracking branch 'upstream/master' into c_keyword
terryjreedy Jul 7, 2020
76053bf
News item.
terryjreedy Jul 7, 2020
8d53070
Filter keywords by length and previous inclusion.
terryjreedy Jul 7, 2020
561a52a
Revise completions doc.
terryjreedy Jul 8, 2020
31b2fc3
that lists
terryjreedy Jul 8, 2020
f8a8cad
Add date directive.
terryjreedy Jul 9, 2020
b898ac0
Merge remote-tracking branch 'upstream/master' into c_keyword
terryjreedy Jul 9, 2020
ee2450b
Revise news item.
terryjreedy Jul 9, 2020
061d96b
Include all keywords.
terryjreedy Jul 9, 2020
f4fe920
Revise revised text.
terryjreedy Jul 9, 2020
526db49
Update idle.rst
terryjreedy Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-37765: Add keywords to IDLE's main completion list
  • Loading branch information
@terryjreedy
terryjreedy committed Aug 5, 2019
commit 15b9ba01342884283e704cedbe85424e9f031512
2 changes: 2 additions & 0 deletions Lib/idlelib/autocomplete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
pop up a list of candidates.
"""
import __main__
import keyword
import os
import string
import sys
Expand Down Expand Up @@ -175,6 +176,7 @@ def fetch_completions(self, what, mode):
namespace = {**__main__.__builtins__.__dict__,
**__main__.__dict__}
bigl = eval("dir()", namespace)
bigl.extend(keyword.kwlist)
Comment thread
terryjreedy marked this conversation as resolved.
Outdated
bigl.sort()
if "__all__" in bigl:
smalll = sorted(eval("__all__", namespace))
Expand Down
5 changes: 3 additions & 2 deletions Lib/idlelib/idle_test/test_autocomplete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,9 @@ def test_fetch_completions(self):
with patch.dict('__main__.__dict__', {'__all__': ['a', 'b']}):
s, b = acp.fetch_completions('', ac.ATTRS)
self.assertEqual(s, ['a', 'b'])
self.assertIn('__name__', b) # From __main__.__dict__
self.assertIn('sum', b) # From __main__.__builtins__.__dict__
self.assertIn('__name__', b) # From __main__.__dict__.
self.assertIn('sum', b) # From __main__.__builtins__.__dict__.
self.assertIn('and', b) # From keyword.kwlist.

# Test attributes with name entity.
mock = Mock()
Expand Down