gh-151364: Add critical sections to kqueue#151376
Open
vstinner wants to merge 1 commit into
Open
Conversation
Member
Author
|
The bug report was only on |
Comment on lines
+1993
to
+2001
| static int | ||
| kqueue_event_init(PyObject *op, PyObject *args, PyObject *kwds) | ||
| { | ||
| int res; | ||
| Py_BEGIN_CRITICAL_SECTION(self); | ||
| res = kqueue_event_init_lock_held(op, args, kwds); | ||
| Py_END_CRITICAL_SECTION(); | ||
| return res; | ||
| } |
Member
There was a problem hiding this comment.
We very rarely add locking to __init__ functions because there are few reasons to support concurrent reinitialization on a live object, and it slows the single-threaded case.
| @@ -0,0 +1,2 @@ | |||
| Add critical sections to :func:`select.kqueue` objects. Patch by Victor | |||
Member
There was a problem hiding this comment.
Do users know what "critical sections" mean in this case? It's probably better to say something like "Fix thread-safety issues in select.kqueue objects," because that's what users care more about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kqueue.kqfdbetweenclose()and theclosedgetter with free-threading build #151364