gh-146102: Catch PyErr_NewException() failure in zlib#151342
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Member
Author
| if (state->ZlibError == NULL) { | ||
| return -1; | ||
| } | ||
| if (PyModule_AddObjectRef(mod, "error", state->ZlibError) < 0) { |
Member
There was a problem hiding this comment.
This isn't strictly necessary, PyModule_AddObjectRef will return -1 if it's NULL. Looking at other modules, they also follow this pattern.
Member
Author
There was a problem hiding this comment.
Oh you're right! I checked PyModule_AddObjectRef() documentation and it's well documented:
To be convenient, the function accepts
NULLvalue with an exception
set. In this case, return-1and just leave the raised exception
unchanged.
Member
Author
|
This change is not needed. I close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.