Skip to content

gh-151126: Fix missing memory error in os._path_splitroot#151339

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-151126-os
Jun 11, 2026
Merged

gh-151126: Fix missing memory error in os._path_splitroot#151339
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-151126-os

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@sobolevn sobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 11, 2026
Open
serhiy-storchaka
serhiy-storchaka approved these changes Jun 11, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I suspect that the NEWS entry is not accurate.

Comment thread Misc/NEWS.d/next/Library/2026-06-11-16-25-38.gh-issue-151126.bh_Usy.rst Outdated
@@ -0,0 +1 @@
Fix :exc:`MemoryError` in :func:`!os._path_splitroot`.

@serhiy-storchaka serhiy-storchaka Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it fixes not MemoryError, but crash if memory allocation failed.

@sobolevn sobolevn Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated!

@sobolevn sobolevn enabled auto-merge (squash) June 11, 2026 15:22
@sobolevn sobolevn merged commit 10595b1 into python:main Jun 11, 2026
54 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151360 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 11, 2026
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151361 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 11, 2026
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151362 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 11, 2026
sobolevn added a commit that referenced this pull request Jun 11, 2026
@miss-islington @sobolevn
[3.13] gh-151126: Fix missing memory error in os._path_splitroot (G…
5a92c74 
…H-151339) (#151362)

gh-151126: Fix missing memory error in `os._path_splitroot` (GH-151339)
(cherry picked from commit 10595b1)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jun 11, 2026
@miss-islington @sobolevn
[3.14] gh-151126: Fix missing memory error in os._path_splitroot (G…
7fe3ddc 
…H-151339) (#151361)

gh-151126: Fix missing memory error in `os._path_splitroot` (GH-151339)
(cherry picked from commit 10595b1)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jun 11, 2026
@miss-islington @sobolevn
[3.15] gh-151126: Fix missing memory error in os._path_splitroot (G…
b53743f 
…H-151339) (#151360)

gh-151126: Fix missing memory error in `os._path_splitroot` (GH-151339)
(cherry picked from commit 10595b1)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @serhiy-storchaka