Skip to content

gh-101100: Fix Sphinx nitpick in unittest.mock.rst#151302

Merged
StanFromIreland merged 1 commit into
python:mainfrom
cmaloney:fix_unittest_mock_nit
Jun 11, 2026
Merged

gh-101100: Fix Sphinx nitpick in unittest.mock.rst#151302
StanFromIreland merged 1 commit into
python:mainfrom
cmaloney:fix_unittest_mock_nit

Conversation

@cmaloney

@cmaloney cmaloney commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Removes from .nitignore. GH-124106 fixed most the warnings but left this one unfixed. GH-113163 fixed many of the dunders referring to the general definitions but this case refers to implementing a mock. Match what __eq__ and __ne__ did a few lines before to refer to an implementing instance.

Removes from `.nitignore`. pythonGH-124106 fixed most the warnings but left
this one unfixed. pythonGH-113163 fixed many of the dunders referring to the
general definitions but this case refers to implementing a mock. Match
what `__eq__` and `__ne__` did a few lines before to refer to an
implementing instance.
@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33088676 | 📁 Comparing ef7c0b2 against main (84630e2)

  🔍 Preview build  

1 file changed
± library/unittest.mock.html

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 11, 2026
@StanFromIreland StanFromIreland merged commit b18168c into python:main Jun 11, 2026
46 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @cmaloney for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151355 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 11, 2026
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151356 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 11, 2026
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151357 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 11, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 11, 2026
StanFromIreland pushed a commit that referenced this pull request Jun 11, 2026
(cherry picked from commit b18168c)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
StanFromIreland pushed a commit that referenced this pull request Jun 11, 2026
… (#151356)

(cherry picked from commit b18168c)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
StanFromIreland pushed a commit that referenced this pull request Jun 11, 2026
… (#151355)

(cherry picked from commit b18168c)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
@cmaloney cmaloney deleted the fix_unittest_mock_nit branch June 11, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants