gh-148722: Make code objects support cyclic GC#151155
Open
iamrajhans wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix code-object reference cycles in GIL-enabled builds by making code objects participate in cyclic garbage collection.
The change uses GC allocation and deallocation for code objects in all builds, enables
tp_traverse, and visitsco_consts. It also adds a regression test that verifies a cycle fromco_constsback to the code object is collected.Closes #148722.
Tests:
make -j8./python.exe -m test test_code test_marshal test_gc