gh-149640: Add new GitHub action to test lazy_imports=all against test suite#151105
Draft
brittanyrey wants to merge 2 commits into
Draft
gh-149640: Add new GitHub action to test lazy_imports=all against test suite#151105brittanyrey wants to merge 2 commits into
brittanyrey wants to merge 2 commits into
Conversation
| branches: &branches | ||
| - 'main' | ||
| - '3.*' | ||
| paths-ignore: &paths-ignore |
Member
There was a problem hiding this comment.
Generally, our actions use the results from compute-changes.py.
| env: | ||
| FORCE_COLOR: 1 | ||
|
|
||
| jobs: |
Member
There was a problem hiding this comment.
This job failing won't block merge, for that we'd have to wire it into:
cpython/.github/workflows/build.yml
Line 653 in 54de547
Maybe this could be reusable-test-lazy-imports.yml with jobs initiated in build.yml?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new action to run the CPython test suite with
lazy_imports=allset as suggested in this comment.#149640
-X lazy_imports=allmore? #149640