Skip to content

gh-150633: Minor improvement of a newly added test#151103

Merged
warsaw merged 1 commit into
python:mainfrom
warsaw:gh-150633-cleanup
Jun 8, 2026
Merged

gh-150633: Minor improvement of a newly added test#151103
warsaw merged 1 commit into
python:mainfrom
warsaw:gh-150633-cleanup

Conversation

@warsaw
Copy link
Copy Markdown
Member

@warsaw warsaw commented Jun 8, 2026 •
edited by bedevere-app Bot
Loading

@warsaw warsaw self-assigned this Jun 8, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 8, 2026
Closed
@warsaw warsaw added skip news needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed awaiting core review labels Jun 8, 2026
@warsaw warsaw enabled auto-merge (squash) June 8, 2026 18:51
KowalskiThomas
KowalskiThomas reviewed Jun 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good point, thanks for fixing.

@warsaw warsaw merged commit fccf67a into python:main Jun 8, 2026
57 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Jun 8, 2026

Thanks @warsaw for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 8, 2026

GH-151106 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 8, 2026
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 8, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit fccf67a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/14454) and take a look at the build logs.
  4. Check if the failure is related to this commit (fccf67a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/14454

Failed tests:

  • test_embed

Failed subtests:

  • test_thread_state_ensure - test.test_embed.AuditingTests.test_thread_state_ensure

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 948, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_embed.py", line 2036, in test_thread_state_ensure
    self.run_embedded_interpreter("test_thread_state_ensure")
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_embed.py", line 161, in run_embedded_interpreter
    self.assertEqual(p.returncode, returncode,
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
                     "bad returncode %d, stderr is %r" %
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     (p.returncode, err))
                     ^^^^^^^^^^^^^^^^^^^^
AssertionError: -6 != 0 : bad returncode -6, stderr is "_testembed: ./Programs/_testembed.c:2741: test_thread_state_ensure: Assertion `_Py_atomic_load_int(&data.done) == 1' failed.\n"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

1 more reviewer

@KowalskiThomas KowalskiThomas KowalskiThomas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@warsaw warsaw

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@warsaw @bedevere-bot @KowalskiThomas