Skip to content

gh-145177: Bump emscripten version to 4.0.19 #150926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hoodmane wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

gh-145177: Bump emscripten version to 4.0.19 #150926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14645f4
gh-145177: Bump emscripten version to 4.0.18
hoodmane Jun 3, 2026
56f8f31
Use 4.0.19
hoodmane Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ def test_ios_ver(self):

def test_libc_ver(self):
if support.is_emscripten:
assert platform.libc_ver() == ("emscripten", "4.0.12")
assert platform.libc_ver() == ("emscripten", "4.0.19")
return
# check that libc_ver(executable) doesn't raise an exception
if os.path.isdir(sys.executable) and \
Expand Down
2 changes: 1 addition & 1 deletion Platforms/emscripten/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Any data that can vary between Python versions is to be kept in this file.
# This allows for blanket copying of the Emscripten build code between supported
# Python versions.
emscripten-version = "4.0.12"
emscripten-version = "4.0.19"
node-version = "24"
test-args = [
"-m", "test",
Expand Down
6 changes: 5 additions & 1 deletion Platforms/emscripten/streams.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const prepareBuffer = (buffer, offset, length) =>

const TTY_OPS = {
ioctl_tiocgwinsz(tty) {
return tty.devops.ioctl_tiocgwinsz?.();
return tty.devops.ioctl_tiocgwinsz?.() ?? [24, 80];
},
};

Expand Down Expand Up @@ -188,6 +188,10 @@ class NodeReader {
fsync() {
nodeFsync(this.nodeStream.fd);
}

ioctl_tiocgwinsz() {
return [this.nodeStream.rows ?? 24, this.nodeStream.columns ?? 80];
}
}

class NodeWriter {
Expand Down
Loading