gh-150737: Optimize bytecode for leading null unpack cases such as the ast.unparse empty set representation.#150812
Open
gesslerpd wants to merge 3 commits into
Open
gh-150737: Optimize bytecode for leading null unpack cases such as the ast.unparse empty set representation.#150812gesslerpd wants to merge 3 commits into
ast.unparse empty set representation.#150812gesslerpd wants to merge 3 commits into
Conversation
Includes the branch-local test expectations for the leading-only behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preferred implementation of the proposal in issue.
This change strives to be as self contained as possible but requires adding
starunpack_helper_impl(..., start, ...)argument to supporteltsslice to ignore leading AST starred node.Less intrusive alternate implementation can be viewed here (slight behavioral differences shown in the tests): f857d88#diff-3cbf15668c31488528b7ab0f903c674a0ecf550f4f53c1be6cf8cd965246c2a0
BUILD_SET 0#150737