gh-150534: Add C23 math "*pi" functions#150555
Open
jepler wants to merge 6 commits into
Open
Conversation
* Add tests * Add documentation * Add configure-time checks for function presence * Regenerate configure No news item added, pending creation of a github issue. As committed, the local implementation of the functions is always used. For production, the #undefs should be removed so that the presence of the functions is detected by configure and used by mathmodule.
Documentation build overview
4 files changed± library/lzma.html± library/math.html± whatsnew/3.16.html± whatsnew/changelog.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #150534 and https://discuss.python.org/t/add-half-turns-functions-cospi-et-al-to-math-module-following-c23-ieee754-2019/107550/5 for discussion and context.
The following functions are added to the math module:
The following aspects of a new feature are covered in this pull request:
The
math_testcases.txtcases are based on glibc's test cases, and their input & output values have been used. I don't know whether these test cases will pass on other platforms, it depends on the quality of the platform trig functionality which is not previously tested so extensively. These cases may need to be revisited if they do not pass everywhere.Closes: #150534