Skip to content

gh-150505: fix data race in Unpickler_set_memo under free-threading #150550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AhmedMagdy9876 wants to merge 4 commits into
base: main
Choose a base branch
from
+12 −0
Open

gh-150505: fix data race in Unpickler_set_memo under free-threading #150550

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61839ca
gh-150505: fix data race in Unpickler_set_memo under free-threading
May 28, 2026
6f465f9
gh-150505: Revert "fix data race in Unpickler_set_memo under free-thr…
May 28, 2026
aef265f
gh-150505: document that Pickler and Unpickler are not thread-safe
May 28, 2026
a540d41
gh-150505: remove unnecessary NEWS entry for docs-only change
May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Doc/library/pickle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,12 @@ The :mod:`!pickle` module exports three classes, :class:`Pickler`,
It is an error if *buffer_callback* is not ``None`` and *protocol* is
``None`` or smaller than 5.

.. note::
:class:`Pickler` objects are not thread-safe. Sharing a single
:class:`Pickler` instance across multiple threads without external
synchronization leads to undefined behavior. Use a separate instance
per thread.

.. versionchanged:: 3.8
The *buffer_callback* argument was added.

Expand Down Expand Up @@ -430,6 +436,12 @@ The :mod:`!pickle` module exports three classes, :class:`Pickler`,
an :ref:`out-of-band <pickle-oob>` buffer view. Such buffers have been
given in order to the *buffer_callback* of a Pickler object.

.. note::
:class:`Unpickler` objects are not thread-safe. Sharing a single
:class:`Unpickler` instance across multiple threads without external
synchronization leads to undefined behavior. Use a separate instance
per thread.

.. versionchanged:: 3.8
The *buffers* argument was added.

Expand Down
Loading