gh-148508: Add another common pattern for iOS SSL failures#150442
Open
freakboy3742 wants to merge 2 commits into
Open
gh-148508: Add another common pattern for iOS SSL failures#150442freakboy3742 wants to merge 2 commits into
freakboy3742 wants to merge 2 commits into
Conversation
Contributor
Author
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 5e9b009 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150442%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_servertest fails intermittently on the iOS buildbot because an SSL error doesn't raise the expected TLS handshake error.This test already has an escape clause that allows a skip under certain error conditions (raising a ConnectionError, an OSError, or an SSL error with "wrong version number"). #148536 added a pattern for one type of iOS failure; this PR adds a second failure mode that is observed (simplifying the test into a single regex).
It also tweaks the iOS logging regex to strip an additional space; this should aid Bevedere in reporting stack traces when failures occur.