Skip to content

gh-149879: Fix test_concurrent_futures on Cygwin #150415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vstinner wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −6
Open

gh-149879: Fix test_concurrent_futures on Cygwin #150415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192e1fd
gh-149879: Fix test_concurrent_futures on Cygwin
vstinner May 25, 2026
c0ea488
Don't check BrokenProcessPool.__cause__
vstinner May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/test_concurrent_futures/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ def test_spawn(self):
self._test(ProcessPoolSpawnFailingInitializerTest)

@support.skip_if_sanitizer("TSAN doesn't support threads after fork", thread=True)
@unittest.skipIf(sys.platform == "cygwin",
"Forkserver is not available on Cygwin")
def test_forkserver(self):
self._test(ProcessPoolForkserverFailingInitializerTest)

Expand Down
11 changes: 6 additions & 5 deletions Lib/test/test_concurrent_futures/test_process_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,12 @@ def test_traceback_when_child_process_terminates_abruptly(self):
with self.assertRaises(BrokenProcessPool) as bpe:
future.result()

cause = bpe.exception.__cause__
self.assertIsInstance(cause, futures.process._RemoteTraceback)
self.assertIn(
f"terminated abruptly with exit code {exit_code}", cause.tb
)
if sys.platform != 'cygwin':
cause = bpe.exception.__cause__
self.assertIsInstance(cause, futures.process._RemoteTraceback)
self.assertIn(
f"terminated abruptly with exit code {exit_code}", cause.tb
)

@warnings_helper.ignore_fork_in_thread_deprecation_warnings()
@hashlib_helper.requires_hashdigest('md5')
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_concurrent_futures/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def get_context(self):
_check_system_limits()
except NotImplementedError:
self.skipTest("ProcessPoolExecutor unavailable on this system")
if sys.platform == "win32":
if sys.platform in ("win32", "cygwin"):
self.skipTest("require unix system")
if support.check_sanitizer(thread=True):
self.skipTest("TSAN doesn't support threads after fork")
Expand Down
Loading