gh-150411: fix gc_generation.count race#150413
Open
LindaSummer wants to merge 3 commits into
Open
Conversation
Member
|
Same concerns as #150356 (comment) CC @nascheme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
gh-150411
Root Cause
Refer the analytics in issue gh-150411, it should be a
gc_generation.countupdate during the cyclic object allocation triggered the local allocation count migrated to young generation. Meantime we try to read thegc_generation.countwithout sync caused the race.cpython/Python/gc_free_threading.c
Lines 2017 to 2037 in c714b56
I find this problem during proposing gh-150356. So they have similar reproduce way.
Proposed Changes
I added an atomic relax load guard for the
gc_generation.count.It was protected in other places expect current one.