gh-150406: check result of PyThread_allocate_lock for netdb_lock#150407
Open
KowalskiThomas wants to merge 3 commits into
Open
Conversation
picnixz
reviewed
May 25, 2026
Comment on lines
+1
to
+3
| Fix crash in :mod:`socket` module initialization when :func:`PyThread_allocate_lock` | ||
| fails to allocate ``netdb_lock``: the ``NULL`` return value is now checked and a | ||
| :exc:`MemoryError` is raised instead of dereferencing a null pointer. Patch by |
Member
There was a problem hiding this comment.
You should remove the mention to netdb_lock, it's an implementation detail. Just mention that a possible crash when importing socket is fixed.
Contributor
Author
There was a problem hiding this comment.
Thanks for taking a look; I fixed it. 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150406.
socketis missing a null pointer check onPyThread_allocate_lockreturn value #150406