gh-80198: Improve test_pwd and test_grp#150380
Merged
serhiy-storchaka merged 2 commits intoMay 25, 2026
Merged
Conversation
Fix tests for non-existing names and ids when getpwall()/getgrall() don't return all users/groups. Add tests for out-of-range uids, gid=-1, integer float ids, bytes names, null-terminated names, names with surrogates, empty names, excessive arguments.
Open
Member
Author
|
The new test for gid=-1 fails on macOS (and maybe on other platforms?). Remove it for now. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests for non-existing names and ids when getpwall()/getgrall() don't return all users/groups.
Add tests for out-of-range uids,
gid=-1,integer float ids, bytes names, null-terminated names, names with surrogates, empty names, excessive arguments.