Skip to content

[3.15] gh-150258: Show relative percentage on Tachyon flamegraph (GH-150266) #150312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
May 23, 2026
+13 −0
Merged

[3.15] gh-150258: Show relative percentage on Tachyon flamegraph (GH-150266) #150312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Lib/profiling/sampling/_flamegraph_assets/flamegraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ let invertedData = null;
let currentThreadFilter = 'all';
let isInverted = false;
let useModuleNames = true;
let zoomedNodeValue = null;

// Heat colors are now defined in CSS variables (--heat-1 through --heat-8)
// and automatically switch with theme changes - no JS color arrays needed!
Expand Down Expand Up @@ -316,6 +317,7 @@ function createPythonTooltip(data) {
const selfSamples = d.data.self || 0;
const selfMs = (selfSamples / 1000).toFixed(2);
const percentage = ((d.data.value / data.value) * 100).toFixed(2);
const relativePercentage = Math.min(100, ((d.data.value / (zoomedNodeValue ?? data.value)) * 100)).toFixed(2);
const calls = d.data.calls || 0;
const childCount = d.children ? d.children.length : 0;
const source = d.data.source;
Expand Down Expand Up @@ -439,6 +441,11 @@ function createPythonTooltip(data) {
<span class="tooltip-stat-label">Percentage:</span>
<span class="tooltip-stat-value accent">${percentage}%</span>

${relativePercentage != percentage && relativePercentage != "100.00" ? `
<span class="tooltip-stat-label">Relative Percentage:</span>
<span class="tooltip-stat-value accent">${relativePercentage}%</span>
` : ''}

${calls > 0 ? `
<span class="tooltip-stat-label">Function Calls:</span>
<span class="tooltip-stat-value">${calls.toLocaleString()}</span>
Expand Down Expand Up @@ -620,6 +627,9 @@ function createFlamegraph(tooltip, rootValue, data) {
const percentage = d.data.value / rootValue;
const level = getHeatLevel(percentage);
return heatColors[level];
})
.onClick(function (d) {
zoomedNodeValue = d.data.value;
});

return chart;
Expand All @@ -629,6 +639,7 @@ function renderFlamegraph(chart, data) {
d3.select("#chart").datum(data).call(chart);
window.flamegraphChart = chart;
window.flamegraphData = data;
zoomedNodeValue = null;
populateStats(data);
}

Expand Down Expand Up @@ -1269,6 +1280,7 @@ function filterDataByThread(data, threadId) {

function resetZoom() {
if (window.flamegraphChart) {
zoomedNodeValue = null;
window.flamegraphChart.resetZoom();
}
}
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tools-Demos/2026-05-22-18-51-09.gh-issue-150258.dh8GVK.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update the tooltip on the Tachyon flame graph to show both absolute and relative percentages.
Loading