[3.14] gh-148450: abc.register needs to update type_version when tp_flags is changed (GH-148623)#150308
Open
cocolato wants to merge 2 commits into
Open
[3.14] gh-148450: abc.register needs to update type_version when tp_flags is changed (GH-148623)#150308cocolato wants to merge 2 commits into
cocolato wants to merge 2 commits into
Conversation
This was referenced May 23, 2026
| /* Keep TYPE_LOCK held while waiting for stop-the-world so no thread | ||
| can reassign a version tag before the flag update. */ | ||
| type_lock_prevent_release(); | ||
| types_stop_world(); |
Contributor
There was a problem hiding this comment.
In 3.14, type flags aren't protected with stop the world pause, you only need type lock here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refer: #148623
abc.registerchangestp_flagswithout updatingtype_version#148450