gh-150167: Make shutil compression probes eager#150279
Closed
RaghunandanKumar wants to merge 1 commit into
Closed
Conversation
02003bf to
66ab25f
Compare
Member
|
Please, don't open PRs when there is still no concrete plan on the issue already. We are still discussing what to do. More importantly, read https://devguide.python.org/ for future contributions especially https://devguide.python.org/getting-started/ai-tools/index.html. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-150167
Make
shutildetect compression-module support eagerly even when Python starts with-X lazy_imports=all.This keeps
_BZ2_SUPPORTEDaccurate whenbz2imports successfully but its_bz2backend would fail once reified. The support probe now temporarily disables lazy imports while importing the compression module, and the regression test exercises that failure mode in a subprocess.Testing
./python.exe -m test test_shutil./python.exe -m test test_lazy_import./python.exe -X lazy_imports=all -S -c "import sys; sys.path.insert(0, TMPDIR); import shutil; print(shutil._BZ2_SUPPORTED)"(with a fakebz2module whose_bz2backend raisesImportError)