Skip to content

[3.12] Replace deprecated action with RtD app (GH-149111)#150233

Merged
hugovk merged 2 commits into
python:3.12from
miss-islington:backport-933e2dd-3.12
May 22, 2026
Merged

[3.12] Replace deprecated action with RtD app (GH-149111)#150233
hugovk merged 2 commits into
python:3.12from
miss-islington:backport-933e2dd-3.12

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor

(cherry picked from commit 933e2dd)

Co-authored-by: Hugo van Kemenade 1324225+hugovk@users.noreply.github.com

(cherry picked from commit 933e2dd)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk

hugovk commented May 22, 2026

Copy link
Copy Markdown
Member

Lint CI is failing:

Error: The action actions/cache@v4 is not allowed in python/cpython because all actions must be pinned to a full-length commit SHA.

That's because two days we checked "[x] Require actions to be pinned to a full-length commit SHA" in the repo settings.

I'll pin the actions here and in older branches, like in the newer branches.

@hugovk

hugovk commented May 22, 2026

Copy link
Copy Markdown
Member

We already hash-pin our actions, the unpinned actions/cache is coming from pre-commit/action:

Download action repository 'pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd' (SHA:2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd)

https://github.com/pre-commit/action/blob/1b06ec171f2f6faa71ed760c4042bd969e4f8b43/action.yml#L15

They've repeatedly rejected pinning it, suggesting forking instead:

We've already switched to j178/prek-action in the newer branches, let's backport that.

@hugovk hugovk merged commit ae9ebe4 into python:3.12 May 22, 2026
26 checks passed
@miss-islington miss-islington deleted the backport-933e2dd-3.12 branch May 22, 2026 11:23
@hugovk hugovk added the needs backport to 3.11 only security fixes label Jun 18, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @miss-islington and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ae9ebe4839ac9a9d19ce7ff1fc8edace42efb7e1 3.11

@bedevere-app

bedevere-app Bot commented Jun 18, 2026

Copy link
Copy Markdown

GH-151657 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jun 18, 2026
hugovk added a commit that referenced this pull request Jun 18, 2026
…#151657)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants