gh-150207: type-crash(): make helpers.c in tokenizer throw a no mem error #150210
Closed
grantlouisherman wants to merge 6 commits into
Closed
gh-150207: type-crash(): make helpers.c in tokenizer throw a no mem error #150210grantlouisherman wants to merge 6 commits into
grantlouisherman wants to merge 6 commits into
Conversation
…alloc fails Signed-off-by: grantlouisherman <grantlouisherman041@gmail.com>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Signed-off-by: grantlouisherman <grantlouisherman041@gmail.com>
aisk
reviewed
May 22, 2026
Comment on lines
+2
to
+4
| fails in the tokenizer's ``_PyTokenizer_translate_newlines`` helper, so the | ||
| out-of-memory condition is propagated as a proper Python exception instead | ||
| of only being recorded in ``tok->done``. |
Member
There was a problem hiding this comment.
Suggested change
| fails in the tokenizer's ``_PyTokenizer_translate_newlines`` helper, so the | |
| out-of-memory condition is propagated as a proper Python exception instead | |
| of only being recorded in ``tok->done``. | |
| fails in the tokenizer's ``_PyTokenizer_translate_newlines`` helper, so the | |
| out-of-memory condition is propagated as a proper Python exception instead | |
| of only being recorded in ``tok->done``. |
|
While this covers _PyTokenizer_translate_newlines which /is/ the major vector for crashes, theoretically _PyTokenizer_tok_new and _PyTokenizer_new_string calls could also return NULL and caude the same problem in _PyTokenizer_FromUTF8. |
Author
|
Sure @stestagg let me update |
Author
|
@aisk @stestagg I moved the PR here https://github.com/python/cpython/pull/150275/commits because I messed up some of the git rebasing stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original report was around this snippet of code:
import resource MB_512 = 512 * 1024 * 1024 resource.setrlimit(resource.RLIMIT_AS, (MB_512, MB_512)) eval("A"* 420000000)Throwing a system error. Based off the write up made in #150207 I felt like there was a fair case to actually show the user a Mem error instead of a system crash.
`>>> import resource
... MB_512 = 512 * 1024 * 1024
... resource.setrlimit(resource.RLIMIT_AS, (MB_512, MB_512))
... eval("A"* 420000000)
...
Traceback (most recent call last):
File "", line 4, in
eval("A"* 420000000)
~~~~^^^^^^^^^^^^^^^^
MemoryError
I think this does provide a bit nicer of an experience but I think I need an actual adult to verify this for me. I also dont know the larger ramifications but it felt worth to throw something up