gh-150060: add asyncio.Task.cancelling_since() to expose first cancellation timestamp#150071
Closed
prince8273 wants to merge 2 commits into
Closed
gh-150060: add asyncio.Task.cancelling_since() to expose first cancellation timestamp#150071prince8273 wants to merge 2 commits into
prince8273 wants to merge 2 commits into
Conversation
…cancellation timestamp
Documentation build overview
|
Member
|
Closing because it is premature to open a PR. Read the devguide first please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Task.cancelling_since()— a new method onasyncio.Taskthat returnsthe event loop time (float) when
cancel()was first called, orNoneifcancellation has not been requested.
Motivation
Task.cancelling()exposes how many cancellation requests were made, but notwhen the first request happened. This makes it impossible to measure
cancellation latency, debug timeout handling, or emit metrics in long-running
async systems.
Changes
Modules/_asynciomodule.c— new struct field, init, clear, traverse, first-cancel timestamp capture, Argument Clinic definition, method impl, method table entryModules/clinic/_asynciomodule.c.h— Clinic-generated wrapperLib/asyncio/tasks.py— pure-Python_PyTaskmirrorLib/test/test_asyncio/test_tasks.py— 3 regression testsDoc/library/asyncio-task.rst— API docs with.. versionadded:: 3.16Misc/NEWS.d/— blurb entry for asyncio: add Task.cancelling_since() to expose first cancellation timestamp #150060Smoke test