gh-150058: asyncio: preserve Task.cancel() msg through fut_waiter and CancelledError paths#150057
Open
prince8273 wants to merge 3 commits into
Open
gh-150058: asyncio: preserve Task.cancel() msg through fut_waiter and CancelledError paths#150057prince8273 wants to merge 3 commits into
prince8273 wants to merge 3 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
2807a14 to
8b1d2b2
Compare
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Task.cancel(msg=...) is called while the task is waiting on another
future, the message was silently discarded in two places:
cancel(): the fast path (_fut_waiter.cancel(msg) returns True)
returned immediately without storing msg in _cancel_message.
__step_run_and_handle_result(): the CancelledError handler called
future_cancel(..., NULL), dropping _cancel_message even when set.
Fix both in tasks.py (_PyTask) and _asynciomodule.c (Task).
Also includes:
test_task_cancel_waiter_future_with_message covers the full
round-trip — cancel with msg while awaiting a future, verify the
message reaches the final CancelledError.