Skip to content

gh-86533: Make Path.mkdir parent_mode tests umask-independent #150040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 2 commits into from
May 19, 2026
Merged

gh-86533: Make Path.mkdir parent_mode tests umask-independent #150040

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa14a5
gh-86533: Make Path.mkdir parent_mode tests umask-independent
gpshead May 18, 2026
064e43d
Merge branch 'main' into gh-86533-fix-mkdir-test-umask
gpshead May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions Lib/test/test_pathlib/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2526,14 +2526,15 @@ def test_mkdir_with_parent_mode(self):
p = self.cls(self.base, 'newdirPM', 'subdirPM')
self.assertFalse(p.exists())
if os.name != 'nt':
# Specify different modes for parent and leaf directories
p.mkdir(0o755, parents=True, parent_mode=0o750)
self.assertTrue(p.exists())
self.assertTrue(p.is_dir())
# Leaf directory gets the mode parameter
self.assertEqual(p.stat().st_mode & 0o777, 0o755)
# Parent directory gets the parent_mode parameter
self.assertEqual(p.parent.stat().st_mode & 0o777, 0o750)
with os_helper.temp_umask(0o022):
# Specify different modes for parent and leaf directories
p.mkdir(0o755, parents=True, parent_mode=0o750)
self.assertTrue(p.exists())
self.assertTrue(p.is_dir())
# Leaf directory gets the mode parameter
self.assertEqual(p.stat().st_mode & 0o777, 0o755)
# Parent directory gets the parent_mode parameter
self.assertEqual(p.parent.stat().st_mode & 0o777, 0o750)

@unittest.skipIf(
is_emscripten or is_wasi,
Expand All @@ -2548,15 +2549,16 @@ def test_mkdir_parent_mode_deep_hierarchy(self):
p = self.cls(self.base, 'level1PM', 'level2PM', 'level3PM')
self.assertFalse(p.exists())
if os.name != 'nt':
p.mkdir(0o755, parents=True, parent_mode=0o700)
self.assertTrue(p.exists())
# Check that all parent directories have parent_mode
level1 = self.cls(self.base, 'level1PM')
level2 = level1 / 'level2PM'
self.assertEqual(level1.stat().st_mode & 0o777, 0o700)
self.assertEqual(level2.stat().st_mode & 0o777, 0o700)
# Leaf directory has the regular mode
self.assertEqual(p.stat().st_mode & 0o777, 0o755)
with os_helper.temp_umask(0o022):
p.mkdir(0o755, parents=True, parent_mode=0o700)
self.assertTrue(p.exists())
# Check that all parent directories have parent_mode
level1 = self.cls(self.base, 'level1PM')
level2 = level1 / 'level2PM'
self.assertEqual(level1.stat().st_mode & 0o777, 0o700)
self.assertEqual(level2.stat().st_mode & 0o777, 0o700)
# Leaf directory has the regular mode
self.assertEqual(p.stat().st_mode & 0o777, 0o755)

@unittest.skipIf(
is_emscripten or is_wasi,
Expand Down Expand Up @@ -2593,11 +2595,12 @@ def test_mkdir_parent_mode_same_as_mode(self):
p = self.cls(self.base, 'samedirPM', 'subdirPM')
self.assertFalse(p.exists())
if os.name != 'nt':
p.mkdir(0o705, parents=True, parent_mode=0o705)
self.assertTrue(p.exists())
# Both directories should have the same mode
self.assertEqual(p.stat().st_mode & 0o777, 0o705)
self.assertEqual(p.parent.stat().st_mode & 0o777, 0o705)
with os_helper.temp_umask(0o022):
p.mkdir(0o705, parents=True, parent_mode=0o705)
self.assertTrue(p.exists())
# Both directories should have the same mode
self.assertEqual(p.stat().st_mode & 0o777, 0o705)
self.assertEqual(p.parent.stat().st_mode & 0o777, 0o705)

@needs_symlinks
def test_symlink_to(self):
Expand Down
Loading