Skip to content

gh-84943: Add support for 'directonly' and 'innocuous' flags for user-defined functions#149961

Open
jbosboom wants to merge 1 commit into
python:mainfrom
jbosboom:sqlite-innocuous-directonly
Open

gh-84943: Add support for 'directonly' and 'innocuous' flags for user-defined functions#149961
jbosboom wants to merge 1 commit into
python:mainfrom
jbosboom:sqlite-innocuous-directonly

Conversation

@jbosboom
Copy link
Copy Markdown
Contributor

@jbosboom jbosboom commented May 17, 2026

Based on #20398, hence Co-authored-by. The flags have also been added to create_window_function, which did not exist at the time. apply_deterministic_flag_if_supported was dropped because all stable Python versions require SQLite version 3.15.2 or later. The other two apply-flag-if-supported functions were modified to only raise when the flag is True. The tests were moved to their new location with updated style and some unnecessary SQL statements were dropped. The documentation now links to the SQLite documentation, which seems to be the prevailing style, rather than repeating it inline.

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 17, 2026

Documentation build overview

📚 cpython-previews | 🛠️ Build #32727528 | 📁 Comparing 9700f31 against main (acefff9)

  🔍 Preview build  

2 files changed
± library/sqlite3.html
± whatsnew/changelog.html

…r user-defined functions

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@jbosboom jbosboom force-pushed the sqlite-innocuous-directonly branch from 725a8cc to 9700f31 Compare May 17, 2026 20:23
@jbosboom
Copy link
Copy Markdown
Contributor Author

The CI job failed due to a DNS problem. The other sanitizer jobs succeeded, so I think it just needs to be re-run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant