Skip to content

gh-149879: Don't import msvcrt in _pyio on Cygwin#149899

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pyio
May 15, 2026
Merged

gh-149879: Don't import msvcrt in _pyio on Cygwin#149899
vstinner merged 1 commit into
python:mainfrom
vstinner:pyio

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented May 15, 2026 •
edited by bedevere-app Bot
Loading

The msvcrt extension module cannot be built on Cygwin.

@vstinner
pythongh-149879: Don't import msvcrt in _pyio on Cygwin
7addb4f 
The msvcrt extension module cannot be built on Cygwin.
@bedevere-app bedevere-app Bot mentioned this pull request May 15, 2026
Open
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented May 15, 2026

This change fix a regression introduced by commit f0f55a0 in 2015. It does fix the issue reported in 2016: #69069 (comment).

@vstinner vstinner mentioned this pull request May 15, 2026
Closed
@vstinner vstinner enabled auto-merge (squash) May 15, 2026 20:20
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented May 15, 2026

The macos-26 job failed with:

FAIL: test_trampoline_works_with_forks (test.test_perf_profiler.TestPerfTrampoline.test_trampoline_works_with_forks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/cpython/cpython/Lib/test/test_perf_profiler.py", line 145, in test_trampoline_works_with_forks
    self.assertEqual(process.returncode, 0)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 11 != 0

That's the unrelated issue gh-149156.

@vstinner vstinner merged commit 1441f2f into python:main May 15, 2026
93 of 95 checks passed
@vstinner vstinner deleted the pyio branch May 15, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner