Skip to content

gh-149029: Update SQLite to 3.53.1 for binary releases#149767

Merged
ned-deily merged 1 commit into
python:mainfrom
adamchainz:sqlite_3.53.1
May 27, 2026
Merged

gh-149029: Update SQLite to 3.53.1 for binary releases#149767
ned-deily merged 1 commit into
python:mainfrom
adamchainz:sqlite_3.53.1

Conversation

@adamchainz
Copy link
Copy Markdown
Contributor

Fixes #149029. Copied from #137135. Supercedes #149030.

@mhsmith, please can you update the Android SQLite build again?

@gpshead, can you push the source to cpython-source-deps?

@freakboy3742
Copy link
Copy Markdown
Contributor

@adamchainz I've just tagged and released SQLite 3.53.1 for Android, and re-started the Android builds on this PR.

@gpshead
Copy link
Copy Markdown
Member

gpshead commented May 13, 2026

I added 3.53.1 to cpython-source-deps. python/cpython-source-deps@7bf8953

cpython-source-deps]└2 sqlite(+0/-0)* ± openssl sha3-256 sqlite-amalgamation-3530100.zip
SHA3-256(sqlite-amalgamation-3530100.zip)= 3c07136e4f6b5dd0c395be86455014039597bc65b6851f7111e88f71b6e06114

Comment thread Mac/BuildScript/build-installer.py Outdated
checksum="a3db587a1b92ee5ddac2f66b3edb41b26f9c867275782d46c3a088977d6a5b18",
name="SQLite 3.53.1",
url="https://www.sqlite.org/2026/sqlite-autoconf-3530100.tar.gz",
checksum="36ca143645cf76997d07b66e9244c636b8ccdec64a1d50558259c4e415e6558b",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, build-installer.py still requires a sha2-256 checksum, not a sha3-256. That would be:
"83e6b2020a034e9a7ad4a72feea59e1ad52f162e09cbd26735a3ffb98359fc4f".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that subtlety and finding the right hash.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 14, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@adamchainz
Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 14, 2026

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from ned-deily May 14, 2026 21:40
Copy link
Copy Markdown
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the macOS part looks good to me.

@zooba
Copy link
Copy Markdown
Member

zooba commented May 27, 2026

LGTM

@ned-deily ned-deily merged commit 9242700 into python:main May 27, 2026
55 of 56 checks passed
@bedevere-bot
Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 9242700.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/14363) and take a look at the build logs.
  4. Check if the failure is related to this commit (9242700) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/14363

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 938, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>

@ned-deily ned-deily added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 28, 2026
@miss-islington-app
Copy link
Copy Markdown

Thanks @adamchainz for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 28, 2026

GH-150559 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 28, 2026
ned-deily added a commit that referenced this pull request May 28, 2026
) (#150559)

(cherry picked from commit 9242700)

Co-authored-by: Adam Johnson <me@adamj.eu>
Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot
Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.15 (tier-1) has failed when building commit 21fa311.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/2019/builds/104) and take a look at the build logs.
  4. Check if the failure is related to this commit (21fa311) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/2019/builds/104

Failed tests:

  • test.test_os.test_os
  • test_embed

Failed subtests:

  • test_thread_state_ensure - test.test_embed.AuditingTests.test_thread_state_ensure
  • test_timerfd_ns_select - test.test_os.test_os.TimerfdTests.test_timerfd_ns_select

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 948, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/test_os/test_os.py", line 4409, in test_timerfd_ns_select
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1


Traceback (most recent call last):
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/test_embed.py", line 2000, in test_thread_state_ensure
    self.run_embedded_interpreter("test_thread_state_ensure")
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/test_embed.py", line 138, in run_embedded_interpreter
    self.assertEqual(p.returncode, returncode,
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
                     "bad returncode %d, stderr is %r" %
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     (p.returncode, err))
                     ^^^^^^^^^^^^^^^^^^^^
AssertionError: -6 != 0 : bad returncode -6, stderr is "_testembed: ./Programs/_testembed.c:2736: test_thread_state_ensure: Assertion `_Py_atomic_load_int(&data.done) == 1' failed.\n"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update macOS and Windows installers to SQLite 3.53.1

6 participants