Skip to content

bpo-15987: Add ast.AST class richcompare methods #14970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flavianh wants to merge 7 commits into from
+242 −5
Closed

bpo-15987: Add ast.AST class richcompare methods #14970

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b9cb098
bpo-15987: Add ast.AST class richcompare methods
Mar 27, 2020
c82f468
Credit Louie Lu for original code
Mar 27, 2020
4d14244
Check int vs float and bool vs int inequality
Mar 27, 2020
d99ff0a
improve tests
isidentical Mar 27, 2020
15c5f1f
Refactor rich_compare method with resolving refleaks
isidentical Mar 28, 2020
9652964
Implement hashing
isidentical Mar 28, 2020
552232c
use tokenize.open instead of open
isidentical Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve tests
  • Loading branch information
@isidentical
isidentical committed Mar 27, 2020
commit d99ff0a54950f5d15cbaf297a11cef9c010b5e0f
10 changes: 6 additions & 4 deletions Lib/test/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import ast
import dis
import os
import random
import sys
import unittest
import warnings
Expand Down Expand Up @@ -666,12 +667,13 @@ def test_compare_basis(self):
def test_compare_literals(self):
constants = (-20, 20, 20.0, 1, 1.0, True, 0, False, frozenset(), tuple(), "ABCD", "abcd", "中文字", 1e1000, -1e1000)
for next_index, constant in enumerate(constants[:-1], 1):
self.assertEqual(ast.Constant(constant), ast.Constant(constant))
next_constant = constants[next_index]
self.assertNotEqual(ast.Constant(constant), ast.Constant(next_constant))
with self.subTest(literal=constant, next_literal=next_constant):
self.assertEqual(ast.Constant(constant), ast.Constant(constant))
self.assertNotEqual(ast.Constant(constant), ast.Constant(next_constant))

same_looking_literal_cases = [{1, 1.0, True, 1+0j}, {0, 0.0, False, 0+0j}]
for same_looking_literals for same_looking_literal_cases:
for same_looking_literals in same_looking_literal_cases:
for literal in same_looking_literals:
for same_looking_literal in same_looking_literals - {literal}:
self.assertNotEqual(ast.Constant(literal), ast.Constant(same_looking_literal))
Expand All @@ -684,7 +686,7 @@ def test_compare_operators(self):
self.assertNotEqual(ast.Add(), ast.Constant())

def test_compare_stdlib(self):
if test.support.is_resource_enabled("cpu"):
if support.is_resource_enabled("cpu"):
files = STDLIB_FILES
else:
files = random.sample(STDLIB_FILES, 10)
Expand Down
9 changes: 7 additions & 2 deletions Python/Python-ast.c
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.