Skip to content

gh-149676: fix: properly initialise frozendict hash value#149675

Merged
vstinner merged 7 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-properly-initialise-frozendicts-hash-value
May 12, 2026
Merged

gh-149676: fix: properly initialise frozendict hash value#149675
vstinner merged 7 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-properly-initialise-frozendicts-hash-value

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented May 11, 2026 •
edited by bedevere-app Bot
Loading

@KowalskiThomas KowalskiThomas mentioned this pull request May 11, 2026
Closed
@KowalskiThomas KowalskiThomas changed the title fix: properly initialise frozendict hash value gh-149676: fix: properly initialise frozendict hash value May 11, 2026
@KowalskiThomas KowalskiThomas marked this pull request as ready for review May 11, 2026 13:58
vstinner
vstinner reviewed May 11, 2026
View reviewed changes
Comment thread Objects/dictobject.c Outdated
Comment thread Objects/dictobject.c Outdated
Comment thread Lib/test/test_dict.py Outdated
Comment thread Lib/test/test_dict.py Outdated
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-05-11-14-48-56.gh-issue-149676.6aTrw1.rst Outdated
vstinner
vstinner reviewed May 12, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-05-11-14-48-56.gh-issue-149676.6aTrw1.rst Outdated
@vstinner vstinner added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 12, 2026
vstinner
vstinner approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner enabled auto-merge (squash) May 12, 2026 10:21
@vstinner vstinner merged commit f5fb491 into python:main May 12, 2026
61 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 12, 2026

Thanks @KowalskiThomas for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 12, 2026

GH-149717 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 12, 2026
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 12, 2026

Merged. Thanks for your fix!

vstinner added a commit that referenced this pull request May 12, 2026
@miss-islington @KowalskiThomas @vstinner
[3.15] gh-149676: Fix hash(frozendict | frozendict) (GH-149675) (#149717
d3b8611 
)

gh-149676: Fix hash(frozendict | frozendict) (GH-149675)

Fix new_dict_impl() to properly initialize ma_hash on frozendict.
(cherry picked from commit f5fb491)

Co-authored-by: Thomas Kowalski <thom.kowa@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KowalskiThomas @vstinner