Skip to content

bpo-37649: Fix exec_prefix decode check#14897

Merged
zooba merged 1 commit into
python:masterfrom
orivej:patch-1
Sep 9, 2019
Merged

bpo-37649: Fix exec_prefix decode check#14897
zooba merged 1 commit into
python:masterfrom
orivej:patch-1

Conversation

@orivej

@orivej orivej commented Jul 21, 2019

Copy link
Copy Markdown
Contributor

@tirkarthi

Copy link
Copy Markdown
Member

Since it's a code change please open a report at https://bugs.python.org with a description of the change being proposed by this PR. Thanks.

@orivej orivej changed the title Fix exec_prefix decode check bpo-37649: Fix exec_prefix decode check Jul 22, 2019

@mangrisano mangrisano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this PR.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @orivej for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
(cherry picked from commit 09090d0)

Co-authored-by: Orivej Desh <orivej@gmx.fr>
@bedevere-bot

Copy link
Copy Markdown

GH-15801 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
(cherry picked from commit 09090d0)

Co-authored-by: Orivej Desh <orivej@gmx.fr>
@bedevere-bot

Copy link
Copy Markdown

GH-15802 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 9, 2019
(cherry picked from commit 09090d0)

Co-authored-by: Orivej Desh <orivej@gmx.fr>
@orivej

orivej commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

Thank you for merging this PR! Could you help finding someone who could review my other PR, #13986?

miss-islington added a commit that referenced this pull request Sep 9, 2019
(cherry picked from commit 09090d0)

Co-authored-by: Orivej Desh <orivej@gmx.fr>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants