gh-148644: propagate PGO job exit code in PCbuild/build.bat#148645
Open
rdesgroppes wants to merge 1 commit intopython:mainfrom
Open
gh-148644: propagate PGO job exit code in PCbuild/build.bat#148645rdesgroppes wants to merge 1 commit intopython:mainfrom
rdesgroppes wants to merge 1 commit intopython:mainfrom
Conversation
Replace the `if "%clean%"=="false" (...)` block with a `goto :RunPgoJob` so the job runs outside any parenthesized block, where `%ERRORLEVEL%` is not subject to eager evaluation. Save the exit code before `call :Kill` resets it, then propagate it if non-zero.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
I guess so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
if "%clean%"=="false" (...)block with agoto :RunPgoJobso the job runs outside any parenthesized block, where%ERRORLEVEL%is not subject to eager evaluation.Save the exit code before
call :Killresets it, then propagate it if non-zero.PCbuild/build.batdoes not propagate the PGO test run exit code #148644