tests: add utc=False tests for TimedRotatingFileHandler#148642
Open
StepfenShawn wants to merge 1 commit intopython:mainfrom
Open
tests: add utc=False tests for TimedRotatingFileHandler#148642StepfenShawn wants to merge 1 commit intopython:mainfrom
TimedRotatingFileHandler#148642StepfenShawn wants to merge 1 commit intopython:mainfrom
Conversation
Added tests for utc=False in TimedRotatingFileHandler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original tests only covered
utc=Truecase. The TODO comments indicated these tests were missing. This ensures correct behavior when users configure the handler to use local timezone instead of UTC.Added test coverage for the utc=False parameter in:
These tests verify rollover time calculation works correctly when
using local time (utc=False) instead of UTC.