gh-69605: fix PyREPL completions inserted for import statements with spaces#148629
Open
loic-simon wants to merge 2 commits intopython:mainfrom
Open
gh-69605: fix PyREPL completions inserted for import statements with spaces#148629loic-simon wants to merge 2 commits intopython:mainfrom
loic-simon wants to merge 2 commits intopython:mainfrom
Conversation
Fix `from math .<tab>` inserting `from math .ath.integer` instead of `from math.integer`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #148445 (comment)
Turn out the import parser already handled these cases well, the issue was that the parser only replaces the last entered word when inserting a suggestion, but inserted the whole import dotted name
So I added an additional step in
ModuleCompleter.get_completionsto reduce the completions to the portion to insert onlycc @tomasr8