gh-148395: Fix a possible UAF in {LZMA,BZ2,_Zlib}Decompressor#148396
Open
StanFromIreland wants to merge 3 commits intopython:mainfrom
Open
gh-148395: Fix a possible UAF in {LZMA,BZ2,_Zlib}Decompressor#148396StanFromIreland wants to merge 3 commits intopython:mainfrom
{LZMA,BZ2,_Zlib}Decompressor#148396StanFromIreland wants to merge 3 commits intopython:mainfrom
Conversation
emmatyping
approved these changes
Apr 11, 2026
Member
emmatyping
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
{LZMA, BZ2, _Zlib}Decompressor{LZMA,BZ2,_Zlib}Decompressor
picnixz
reviewed
Apr 11, 2026
| with self.assertRaises(TypeError): | ||
| pickle.dumps(BZ2Decompressor(), proto) | ||
|
|
||
| def test_decompressor_reuse_after_tail_copy_memory_error(self): |
Member
There was a problem hiding this comment.
Considering we need to hit an error path with a MemoryError, I'm not sure we really need a test. Sometimes we do add tests, sometimes not. I don't think there is a need to add a test. The test also don't assert that we hit the goto so I don't think we need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{LZMA, BZ2, _Zlib}Decompressor#148395